tdd and readme#71
Conversation
| ```json | ||
| { | ||
| "ok": true, | ||
| "schema_version": 1, |
There was a problem hiding this comment.
did not see a section about backwards compatibility (sorry if I missed it), but need to answer questions like: will the extension reject unknown schema versions? Will it attempt best-effort rendering?
There was a problem hiding this comment.
also will explore this as i test around with more actual mrd files!
| - MRD reader: uses `mrd-python` as the only Stage 1 format parser. | ||
| - Summary JSON: carries schema version, file class, display mode, header summary, stream counts, warnings, raw-only states, and error envelopes. | ||
| - Preview PNG data: uses base64 PNGs for bounded thumbnails and temporary PNG paths for lazy full-size image requests. | ||
| - Webview UI: renders the mosaic, selected image, metadata panel, loading states, unsupported states, and controlled errors. |
There was a problem hiding this comment.
what error views are we going to support? I.e. it would be nice to explicitly list the expected errors we may get (wrong version, wrong format, error in the way file is formatted...there are probably more)
There was a problem hiding this comment.
will explore this as I test with more real-world mrd examples
|
looks good - all the changes cover everything we talked about, thanks for including all that! a few follow up comments but nothing major. excited to try out a first version of the extension soon! |
naegelejd
left a comment
naegelejd
left a comment
There was a problem hiding this comment.
Comprehensive! Good job scoping Stage 1 down to something manageable, with incremental improvements planned.
… backward compatibility for unknown schema versions and what error views will be supported
3 participants
added a brief readme and detailed technical design doc in docs/TECHNICAL_DESIGN.md. requesting review for the TDD to make sure everything looks good and is aligned with expectations.